[#1384] feat(api): Add NullType for representing NULL values
#1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchades
force-pushed
the
literals-3
branch
2 times, most recently
from
d3a56fa to
429a4ee
Compare
mchades
changed the title
NullType for representing NULL values #1384NullType for representing NULL values #1384
mchades
changed the title
NullType for representing NULL values #1384NullType for representing NULL values
jerryshao
reviewed
Jan 10, 2024
| @@ -13,6 +13,8 @@ | |||
|
|
|||
| /** The helper class to create literals to pass into Gravitino. */ | |||
| public class Literals { | |||
| /** Used to represent a null literal. */ | |||
| public static final Literal<Types.NullType> NULL = new LiteralImpl<>(null, Types.NullType.get()); | |||
There was a problem hiding this comment.
Is it a typical way to use NullType for Null value?
There was a problem hiding this comment.
I think so. There are some refer:
- Spark
- Hive has a void type that can convert to any type, I think it is equivalent to
NullType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
NullTypefor representing NULL valuesWhy are the changes needed?
Fix: #1384
Does this PR introduce any user-facing change?
yes, users now can use null literal
How was this patch tested?
UTs added