Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Chinese translation #25

Open
learningpro opened this issue Oct 5, 2023 · 5 comments
Open

Need Chinese translation #25

learningpro opened this issue Oct 5, 2023 · 5 comments

Comments

@learningpro
Copy link

Will you provide Chinese translation ? Or how could I make a pull request on translation

@learningpro
Copy link
Author

datalens-tech/datalens-ui#40
Is any one here can help approve this PR?

@resure
Copy link
Contributor

resure commented Oct 9, 2023

Hi! Thank you for your contribution.

I afraid we can't just merge that PR right now since both our i18n tools and UI components are currently not suitable for Chinese. App probably just won't be able to start.

We need some time to analyze this task and, if needed, adapt our tools.

@learningpro
Copy link
Author

Hi! Thank you for your contribution.

I afraid we can't just merge that PR right now since both our i18n tools and UI components are currently not suitable for Chinese. App probably just won't be able to start.

We need some time to analyze this task and, if needed, adapt our tools.

I read through the code and found that gravity-ui doesn't have cn language, it only has en and ru, maybe we should update gravity-ui/i18n first. https://github.com/gravity-ui/i18n/blob/main/src/index.ts

@resure
Copy link
Contributor

resure commented Oct 13, 2023

I read through the code and found that gravity-ui doesn't have cn language, it only has en and ru, maybe we should update gravity-ui/i18n first. https://github.com/gravity-ui/i18n/blob/main/src/index.ts

Yes, that's the plan — add support for additional languages in gravity i18n, uikit, etc.

We are discussing that with our colleagues (maintainers of gravity libraries) right now, we'll add links to related tasks soon.

@resure
Copy link
Contributor

resure commented Oct 24, 2023

Related issue in Gravity UIKit: gravity-ui/uikit#1065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants