From 7efb01db401721e268ed9d4c5a132515dcdf495f Mon Sep 17 00:00:00 2001 From: KonstantAnxiety <58992437+KonstantAnxiety@users.noreply.github.com> Date: Wed, 27 Mar 2024 13:28:24 +0300 Subject: [PATCH] Revert CH max_execution_time parameter (#404) --- .../dl_connector_clickhouse/core/clickhouse_base/ch_commons.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dl_connector_clickhouse/dl_connector_clickhouse/core/clickhouse_base/ch_commons.py b/lib/dl_connector_clickhouse/dl_connector_clickhouse/core/clickhouse_base/ch_commons.py index 5ce606b24..f1ab3e900 100644 --- a/lib/dl_connector_clickhouse/dl_connector_clickhouse/core/clickhouse_base/ch_commons.py +++ b/lib/dl_connector_clickhouse/dl_connector_clickhouse/core/clickhouse_base/ch_commons.py @@ -63,7 +63,8 @@ def get_ch_settings( # forever-running queries (which is also known to break old-version CH # hosts at around 100_000 second long queries). # Note that in CH the value is rounded down to integer, and 0 seems to mean 'no limit'. - "max_execution_time": max_execution_time if max_execution_time is not None else 3600 * 4, + # TODO: get rid of this parameter or figure out a proper way to use it, bc CH's estimates seem to be way off + "max_execution_time": max_execution_time if max_execution_time is None else 3600 * 4, "readonly": read_only_level, # https://clickhouse.com/docs/en/operations/settings/settings#settings-insert_quorum # INSERT succeeds only when ClickHouse manages to correctly write data to the insert_quorum