-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook After uninstallation, the api is still called in the background #259
Comments
Hi @chenjpu Are you using the simple Notebook component or the more evolved JupyterLabApp component? How do you navigate away? (maybe the Notebook component is still rendered but not shown?) |
using the simple Notebook component use nextjs router(Only one page contains the Notebook component) |
Force to refresh the browser, and the background api access stops. Is it the resource leakage caused by the service when the components are uninstalled? |
jupyter-ui/packages/react/src/components/lumino/Lumino.tsx Lines 30 to 37 in 53f2cd6
When the component is unloaded, the |
That could be the case. that exception is coming from Lumino and hard to remove (ideally it should be). Maybe a temp workaround, a termination action on the Notebook hook could help. |
Fix keydown Event leak(#265) |
Using nextjs technology to integrate Notebook, when the navigation leaves the Notebook edit page, the api background continuously access。
When navigate to the Notebook edit page again, the shortcut keys all fail。
Description
Reproduce
Expected behavior
Context
Browser Output
The text was updated successfully, but these errors were encountered: