Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we get a non-admin git-annex Windows installer? #176

Open
adswa opened this issue Sep 4, 2023 · 3 comments
Open

Can we get a non-admin git-annex Windows installer? #176

adswa opened this issue Sep 4, 2023 · 3 comments

Comments

@adswa
Copy link
Member

adswa commented Sep 4, 2023

This is in the context of datalad/datalad-gooey#425.

Git for Windows can be installed on non-admin User accounts. Users do not have to know an administrator password, and the installation defaults to (something like) C:\Users\<non-admin-username>\AppData\Local\Programs\Git.

The git-annex installer, hower, requires administrative rights and wants to be installed under C:\Program Files\Git, which belongs to the admin account of the system. It also searches for a Git installation only under C:\Program Files\Git an complains if it can't find it there.
git-annex-warning

It would be nice to allow non-admin users an installation, and to have the installation location belong to the non-admin user performing it.

I'm not sure, however, if this is the right repository for this feature request, or if it needs to be issues to git-annex directly. @christian-monch has figured how how to create an installer for DataLad-gooey without admin privileges, and he might have useful insights how a git-annex installer could have the same.

@christian-monch
Copy link

IMHO, it would suffice to change line upstream/master/Build/NullSoftInstaller.hs#144 from

requestExecutionLevel Admin

to

requestExecutionLevel User

This would allow executing the installer as non-admin user. If the user selects an installation directory to which he has write-permissions, the installation should succeed.

Question to all developer here: where should I propose a PR? In this repo or in the upstream repo?

@yarikoptic
Copy link
Member

@joeyh WDYT?

@christian-monch
Copy link

IMHO, it would suffice to change line upstream/master/Build/NullSoftInstaller.hs#144 from

requestExecutionLevel Admin

to

requestExecutionLevel User

[...]

On second thought, that is probably not sufficient. A non-admin installer would need a method to specify an installation directory (probably with a pre-set <user>\AppData\Local\git-annex-value) and adapt the PATH accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants