Exploration on the implementation of remove

[mih]

Maybe this can provide insight into an RF strategy.

It comes in two flavors

    def remove(self, key):
        remote_file = Path(key)
        self._remove_file(key, remote_file)

    def removeexport(self, key, remote_file):
        remote_file = mangle_directory_names(remote_file)
        self._remove_file(key, remote_file)

So it is really just _remove_file(), called with two different values for remote_file.

Strangely, that parameter is not used inside the method, except for getting the ID of DATALAD_ANNEX_SPECIAL_KEYS (a special casing that I believe should not be happening at all: #180).

So its seems the implementation ignores what git-annex knows about the remote-file location. This is likely due to the impossibility of performing reliable lookup-file-by-path actions on dataverse.

[mih]

With #184 the only usage of remote_file would be gone.

[mih]

mih#1 brought more info on the side-effects of _remove_file()