Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two subsequent git-push to a dataverse dataset in filetree mode break it #143

Closed
mih opened this issue Jul 7, 2022 · 6 comments · Fixed by #154
Closed

Two subsequent git-push to a dataverse dataset in filetree mode break it #143

mih opened this issue Jul 7, 2022 · 6 comments · Fixed by #154
Assignees
Labels
bug Something isn't working

Comments

@mih
Copy link
Member

mih commented Jul 7, 2022

It will not replace the exported files, but rather add renamed copies -- which breaks the special remote logic

image

@mih mih added the bug Something isn't working label Jul 7, 2022
@bpoldrack
Copy link
Member

Just FTR when addressing this: IIRC this may depend on whether the previous push was "published" in between.

@mih mih mentioned this issue Jul 7, 2022
@mih
Copy link
Member Author

mih commented Jul 7, 2022

In my case it was two subsequent git-push calls was nothing inbetween.

@bpoldrack bpoldrack self-assigned this Jul 18, 2022
@bpoldrack
Copy link
Member

Looking into this to figure out when and how exactly to replace instead.

@mih
Copy link
Member Author

mih commented Jul 18, 2022

I don't think calling a replace method is the (only) fix to be made. This is happening also when nothing is changed at all. Nothing should be done in this case, not replacing X with X. I think it is worth looking into improving the file identify records. Related: #146

@bpoldrack
Copy link
Member

bpoldrack commented Jul 18, 2022

Yes, I am aware. Also: We can't even replace w/o keeping track of file identifiers. (database id or persistent id, guess the latter)
Hence, need to think about how to do that best.

@bpoldrack
Copy link
Member

bpoldrack commented Jul 18, 2022

This is happening also when nothing is changed at all.

Just noting an observation on this: a datalad push . --to REMOTE w/o any changes not only results in the repo itself being pushed again (under .datalad/dot_git), but in fact everything underneath .datalad, while files outside seem unaffected. Since push should figure what needs pushing, I suppose some check isn't quite right or somehow torpedoed.
Double-checking whether the leading dot issue leads to this. I think checkpresentexport might be incorrect.

checkpresentexport doesn't seem to account for the remote file's directoryLabel at all. So, apart from the leading dot issue, this would be wrong in several scenarios. I think this is one of the main points here leading to pushes where there shouldn't be any in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants