-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add procedure to configure non-annexing of docker metadata #204
base: master
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit c1ffe67 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 93.82% 93.90% +0.07%
==========================================
Files 19 19
Lines 956 968 +12
==========================================
+ Hits 897 909 +12
Misses 59 59 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if cfg_containers
wouldn't be too broad/non-specific, this specific to docker manifests right? so smth more like cfg_dockermanifests2git
(I know - mouth full).
But then I wonder why I didn't ask why you just don't use generic cfg_text2git
? may be that would obliterate the need for the PR as well?
and as with anything else we would need some basic unittest, can see e.g. https://github.com/datalad/datalad/blob/HEAD/datalad/local/tests/test_run_procedure.py#L350 for an example
Co-authored-by: Yaroslav Halchenko <[email protected]>
I will move it to Draft. I guess we should decide first on how/if to proceed with this, or just rely on cfg_text2git may be. |
I think the issue this PR fixes is quite important to fix. Is there anything I can do to help? |
I would say that
I agree that it would be useful to extend this configuration to also work with singularity images (which would be placed in |
resolves #197