Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest QOL improvements #138

Open
CBroz1 opened this issue Jul 1, 2022 · 0 comments
Open

Pytest QOL improvements #138

CBroz1 opened this issue Jul 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Jul 1, 2022

  1. Currently, the full suite of pytests is very time consuming (taking over an hour), as we insert and delete between each test. By adding fixture scope, we could reduce this time significantly.
@pytest.fixture(scope="session")
def ingest_subjects(pipeline, subjects_csv):
    pass # keep as is
  1. Currently, there are DuplicateErrors if _tear_down=False. By adding skip_duplicates to insert functions or pytest markers (e.g., skipif or xfail), we could make better use of non-teardown iterations.
@CBroz1 CBroz1 added the enhancement New feature or request label Jul 1, 2022
@CBroz1 CBroz1 added this to the 2023Q2+ milestone Jul 1, 2022
@CBroz1 CBroz1 changed the title Add fixture scope to pytests Pytest QOL improvements Jul 1, 2022
@kabilar kabilar removed this from the 2023Q2+ milestone Feb 19, 2023
@kabilar kabilar transferred this issue from datajoint/workflow-calcium-imaging Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants