Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cleanup): cleanup of 2 sub-modules #8616

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix(cleanup): cleanup of 2 sub-modules #8616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions metadata-io/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,3 +136,7 @@ sourceSets.main.java.srcDir "${generateOpenApiPojos.outputDir}/src/main/java"
sourceSets.main.resources.srcDir "${generateOpenApiPojos.outputDir}/src/main/resources"

checkstyleMain.exclude '**/generated/**'

clean {
project.delete("$projectDir/generated")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is actually us following non-standard practices. Typically generated classes should be part of the buildDir or build and this is why its required to add this custom logic. I think its probably a bigger lift to correct this everywhere at the moment so going to approve.

}
4 changes: 4 additions & 0 deletions metadata-models/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ tasks.register('generateJsonSchema', GenerateJsonSchemaTask) {
it.setOutputDirectory("$projectDir/src/generatedJsonSchema")
dependsOn generateAvroSchema
}

clean {
project.delete("$projectDir/src/generatedJsonSchema")
}