Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eso): add docs #6981

Conversation

RyanHolstien
Copy link
Collaborator

Adding docs

@github-actions github-actions bot added the docs Issues and Improvements to docs label Jan 9, 2023

<FeatureAvailability/>

This feature adds features to our current search implementation in an effort to make search results more relevant. Included improvements are:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a feature? Or just... a migrating to new sarch doc??

We will continually make search improvements over time, so I'd suggest not naming it "Search Improvements"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's both, it's an overview of the changes that required the reindex and how the reindex impacts users with the additional configurations documented. "Search Improvements" was the naming we used in the town hall so that was what I went with, happy to rename it if you have another suggestion. Maybe just focus on the net new features and call it Stemming & Synonym Support?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I like that. But feel free to diverge on the format - since this really isn't a feature guide. This is more of an "upgrading DataHub guide".

If we need 2 separate docs, 1) to discuss features and 2) to discuss the upgrade steps required, feel free to split in 2.

@david-leifker david-leifker merged commit 33eef5e into datahub-project:feat/elasticsearch-optimization-ext Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants