Fix: span.enter() in async loop causes memory leak

It is explained in: https://onesignal.com/blog/solving-memory-leaks-in-rust/
databendlabs · Jun 17, 2022 · a0a94af · a0a94af
1 parent f633756
commit a0a94af
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/openraft/src/core/mod.rs b/openraft/src/core/mod.rs
@@ -765,9 +765,6 @@ impl<'a, D: AppData, R: AppDataResponse, N: RaftNetwork<D>, S: RaftStorage<D, R>
                 return Ok(());
             }
 
-            let span = tracing::debug_span!("CHrx:LeaderState");
-            let _ent = span.enter();
-
             tokio::select! {
                 Some((msg,span)) = self.core.rx_api.recv() => {
                     self.handle_msg(msg).instrument(span).await?;
@@ -914,9 +911,6 @@ impl<'a, D: AppData, R: AppDataResponse, N: RaftNetwork<D>, S: RaftStorage<D, R>
                 }
                 let timeout_fut = sleep_until(self.core.get_next_election_timeout());
 
-                let span = tracing::debug_span!("CHrx:CandidateState");
-                let _ent = span.enter();
-
                 tokio::select! {
                     _ = timeout_fut => break, // This election has timed-out. Break to outer loop, which starts a new term.
 
@@ -1067,9 +1061,6 @@ impl<'a, D: AppData, R: AppDataResponse, N: RaftNetwork<D>, S: RaftStorage<D, R>
                 return Ok(());
             }
 
-            let span = tracing::debug_span!("CHrx:LearnerState");
-            let _ent = span.enter();
-
             tokio::select! {
                 Some((msg,span)) = self.core.rx_api.recv() => {
                     self.handle_msg(msg).instrument(span).await?;

diff --git a/openraft/src/replication/mod.rs b/openraft/src/replication/mod.rs
@@ -681,9 +681,6 @@ impl<D: AppData, R: AppDataResponse, N: RaftNetwork<D>, S: RaftStorage<D, R>> Re
                 });
             }
 
-            let span = tracing::debug_span!("CHrx:LineRate");
-            let _en = span.enter();
-
             // Check raft channel to ensure we are staying up-to-date
             self.try_drain_raft_rx().await?;
             if self.has_more_log() {