Fix: metrics has to be updated last

Otherwise the application receives updated metrics while the internal raft state is still stale.
databendlabs · Jul 13, 2022 · 8594807 · 8594807
1 parent 2c3024c
commit 8594807
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/openraft/src/core/raft_core.rs b/openraft/src/core/raft_core.rs
@@ -971,7 +971,6 @@ impl<C: RaftTypeConfig, N: RaftNetworkFactory<C>, S: RaftStorage<C>> RaftCore<C,
         Ok(())
     }
 
-    // TODO: make it private
     #[tracing::instrument(level = "debug", skip(self, msg), fields(state = debug(self.engine.state.server_state), id=display(self.id)))]
     pub(crate) async fn handle_api_msg(&mut self, msg: RaftMsg<C, N, S>) -> Result<(), Fatal<C::NodeId>> {
         tracing::debug!("recv from rx_api: {}", msg.summary());

diff --git a/openraft/src/core/replication.rs b/openraft/src/core/replication.rs
@@ -122,11 +122,11 @@ impl<'a, C: RaftTypeConfig, N: RaftNetworkFactory<C>, S: RaftStorage<C>> LeaderS
             }
         };
 
-        self.update_replication_metrics(target, matched);
-
         self.core.engine.update_progress(target, Some(matched));
         self.run_engine_commands(&[]).await?;
 
+        self.update_replication_metrics(target, matched);
+
         Ok(())
     }