Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets #26

Open
colinjbrown opened this issue Aug 24, 2018 · 3 comments
Open

Widgets #26

colinjbrown opened this issue Aug 24, 2018 · 3 comments
Labels
bug enhancement Important soon Should be worked on for next major release

Comments

@colinjbrown
Copy link
Member

From @dakoop on June 28, 2018 20:8

After playing around with ipywidgets, I have some thoughts on making them work with dfkernel.

  1. Widgets should be shown with labels like other outputs (need to redo the widget-specific output area stuff to show the tag), not sure if having them be execute_results or display_datas is a big deal
  2. A widget's value should be referenced just using the the name of that widget, x not x.value as is currently done. Any needs for things like links, jslinks, etc. can be done with some type of widget() call or something.
  3. Every widget should have an observer that triggers execution if necessary. Users should also be able to use an interact_manual analog so that execution is only triggered when a button is clicked
  4. Downstream use of a widget's value is then as simple as y = x + 4

Copied from original issue: colinjbrown/dfkernel#42

@colinjbrown
Copy link
Member Author

From @dakoop on July 3, 2018 20:15

Note that when jupyter-widgets/ipywidgets#2021 is merged into ipywidgets, we get labeled, execute_result widgets.

screen shot 2018-07-03 at 4 14 22 pm

@colinjbrown
Copy link
Member Author

Apparently we do something weird with ipywidgets now, not sure if we always did but a
h = j.value +3 seems to cause issues because we appear to be trying to look inside the IntSlider object?

image

@colinjbrown colinjbrown added bug Important soon Should be worked on for next major release labels May 3, 2024
@colinjbrown
Copy link
Member Author

I can't confirm this is still an issue, on the most recent version this does not appear to still be occurring will leave this open in the event someone else is able to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement Important soon Should be worked on for next major release
Projects
None yet
Development

No branches or pull requests

2 participants