From eca02a63a0f87bf3e9ae623e205c277493a2c5f7 Mon Sep 17 00:00:00 2001 From: Nick B Date: Fri, 18 Oct 2024 21:47:24 -0700 Subject: [PATCH 01/12] Conversion of ids to classes where those ids can be duplicated (to prevent invalid HTML, prevent accessibility issues with certain readers and prevent down-the-line JS issues if we rely on the ids). --- static/css/base.scss | 2 +- static/js/apps/base/components/header_bar/header_logo.tsx | 2 +- static/js/components/content/media_text.tsx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/static/css/base.scss b/static/css/base.scss index 3a79adf932..d05e60d3f3 100644 --- a/static/css/base.scss +++ b/static/css/base.scss @@ -160,7 +160,7 @@ $headings-font-family: $font-family-sans-serif; background: var(--gm-3-white); } -#main-header #main-header-logo { +#main-header .main-header-logo { display: flex; align-items: center; img { diff --git a/static/js/apps/base/components/header_bar/header_logo.tsx b/static/js/apps/base/components/header_bar/header_logo.tsx index 36ff0eb619..ffa2e81d23 100644 --- a/static/js/apps/base/components/header_bar/header_logo.tsx +++ b/static/js/apps/base/components/header_bar/header_logo.tsx @@ -51,7 +51,7 @@ const HeaderLogo = ({ return (
{logoPath && ( -