From d4cd993d174a75f67ab8541038def35809e43fbd Mon Sep 17 00:00:00 2001 From: Nick B Date: Wed, 23 Oct 2024 19:06:56 -0700 Subject: [PATCH] Resolution to Codacy analysis findings and fix to link source issue. --- static/css/content/chips.scss | 2 ++ static/js/apps/homepage/app.tsx | 4 ++-- static/js/components/content/link_chips.tsx | 7 ++++--- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/static/css/content/chips.scss b/static/css/content/chips.scss index 3f1eb1f9fb..e66bb1633f 100644 --- a/static/css/content/chips.scss +++ b/static/css/content/chips.scss @@ -23,6 +23,7 @@ @include var.title_xs; margin-bottom: calc(#{var.$spacing} * 3); } + .chip-container { margin: 0; padding: 0; @@ -34,6 +35,7 @@ max-width: 100%; } } + .chip-item { display: block; list-style: none; diff --git a/static/js/apps/homepage/app.tsx b/static/js/apps/homepage/app.tsx index abc1c97163..f530d30978 100644 --- a/static/js/apps/homepage/app.tsx +++ b/static/js/apps/homepage/app.tsx @@ -24,7 +24,7 @@ import React, { ReactElement } from "react"; import Build from "../../components/content/build_your_own"; import HeroVideo from "../../components/content/hero_video"; -import LinkChips, { LinkChip } from "../../components/content/link_chips"; +import { LinkChip, LinkChips } from "../../components/content/link_chips"; import Partners from "../../components/content/partners"; import SampleQuestions from "../../components/content/sample_questions"; import Tools from "../../components/content/tools"; @@ -59,7 +59,7 @@ export function App({ const topicLinkChips: LinkChip[] = topics.map((topic) => ({ id: topic.id, title: topic.title, - url: topic.url, + url: topic.browseUrl, })); return ( diff --git a/static/js/components/content/link_chips.tsx b/static/js/components/content/link_chips.tsx index 2cdb0f27ce..39de5cd42e 100644 --- a/static/js/components/content/link_chips.tsx +++ b/static/js/components/content/link_chips.tsx @@ -44,7 +44,10 @@ interface LinkChipsProps { linkChips: LinkChip[]; } -const LinkChips = ({ title, linkChips }: LinkChipsProps): ReactElement => { +export const LinkChips = ({ + title, + linkChips, +}: LinkChipsProps): ReactElement => { return (
@@ -72,5 +75,3 @@ const LinkChips = ({ title, linkChips }: LinkChipsProps): ReactElement => {
); }; - -export default LinkChips;