Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): field_name not being accepted in open-search and elastic-search in freshness metric #96

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

WeryZebra-Yue
Copy link
Contributor

Fixes/Implements #90

Description

opensearch and elasticsearch in freshness metric is not accepting field_name.

Type of change

Delete irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally Tested

@WeryZebra-Yue WeryZebra-Yue marked this pull request as ready for review September 18, 2023 14:25
@WeryZebra-Yue WeryZebra-Yue added the 🐞 bug Something isn't working label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (75b36e1) 84.72% compared to head (76cbbc9) 84.72%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          33       33           
  Lines        1368     1368           
=======================================
  Hits         1159     1159           
  Misses        209      209           
Files Changed Coverage Δ
...achecks/core/configuration/configuration_parser.py 77.94% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhankarb subhankarb merged commit f799a91 into datachecks:main Sep 19, 2023
7 checks passed
@WeryZebra-Yue WeryZebra-Yue deleted the freshness-fix branch September 19, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: field_name not being accepted in open-search and elastic-search in freshness metric
2 participants