Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sql schema hardcoded in method query_get_table_metadata #212 #213

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: sql schema hardcoded in method query_get_table_metadata #212 #213

merged 1 commit into from
Aug 9, 2024

Conversation

Ryuk-me
Copy link
Contributor

@Ryuk-me Ryuk-me commented Aug 8, 2024

Fixes/Implements

Description

Get table name from defined schema

Type of change

Remove schema param from get_table_names method, if schema is not passed it'll use default schema for the database.

Delete irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Locally Tested
  • Needs Testing From Production

@subhankarb subhankarb merged commit c53f80f into datachecks:main Aug 9, 2024
6 checks passed
@Ryuk-me Ryuk-me deleted the schema-fix branch August 9, 2024 04:54
@Ryuk-me Ryuk-me mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhankarb subhankarb subhankarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ryuk-me @subhankarb