-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ggsave instead of pdf - dev.off to save plots #148
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/r-intro-geospatial/compare/md-outputs..md-outputs-PR-148 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-01-11 14:01:20 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me.
Optional addition might be showing learners how to save a plot to an object and then explicitly save a plot object. I've added something similar to my something I'm customizing of the genomics R lesson but I don't think it is necessary.
Co-authored-by: Sarah Stevens <[email protected]>
Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 0ab69c2 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-01-11 14:09:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 266eedb Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-12 00:35:10 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Auto-generated via {sandpaper} Source : bbf1ffe Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-03-19 00:21:09 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 397ea0c Branch : main Author : Alber Sánchez <[email protected]> Time : 2024-01-11 14:07:23 +0000 Message : Merge pull request #148 from albhasan/ggsave_121 Use ggsave instead of pdf - dev.off to save plots
Remove the calls to
pdf
anddev.off
to save plots in lesson 8. We useggsave
instead since it fits better with plots built using theggplot2
package.This PR:
Closes #121