Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query duration bucket in the metrics #2

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Add query duration bucket in the metrics #2

merged 3 commits into from
Apr 4, 2023

Conversation

christopherzli
Copy link

@christopherzli christopherzli commented Apr 1, 2023 •
edited
Loading

Tested in the integration test cluster
Screen Shot 2023-04-03 at 2 33 57 PM
Screen Shot 2023-04-03 at 2 34 16 PM

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@christopherzli christopherzli changed the base branch from main to db_main April 1, 2023 02:36
christopherzli pushed a commit to christopherzli/thanos that referenced this pull request Apr 1, 2023
@jnyi
Merge pull request databricks#2 from jnyi/issue-6167
6734594 
Issue 6167
jnyi
jnyi previously requested changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@jnyi jnyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind test and verify this works as expected? either local or using integration test cluseter

hczhu
hczhu previously approved these changes Apr 4, 2023
View reviewed changes
Copy link

@hczhu hczhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@christopherzli
Copy link
Author

Address comment to add unit test and logging

davidyuanfs
davidyuanfs approved these changes Apr 4, 2023
View reviewed changes
Copy link

@davidyuanfs davidyuanfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopherzli christopherzli merged commit 6a22468 into databricks:db_main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidyuanfs davidyuanfs davidyuanfs approved these changes

@mingzhao-db mingzhao-db Awaiting requested review from mingzhao-db

@jnyi jnyi Awaiting requested review from jnyi

@hczhu hczhu Awaiting requested review from hczhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopherzli @hczhu @davidyuanfs @jnyi