Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Migrate to new unique databricks hostnames #34

Closed
sdebruyn opened this issue May 4, 2020 · 7 comments · Fixed by #114
Closed

[FEATURE] Migrate to new unique databricks hostnames #34

sdebruyn opened this issue May 4, 2020 · 7 comments · Fixed by #114
Labels
azure Occurring on Azure cloud feature New feature or request
Milestone

Comments

@sdebruyn
Copy link
Contributor

sdebruyn commented May 4, 2020

Is your feature request related to a problem? Please describe.
Currently not a problem, but it's advised to start using the new unique URLs for each Databricks workspace as documented in https://docs.microsoft.com/en-us/azure/databricks/release-notes/product/2020/april#unique-urls-for-each-azure-databricks-workspace

Describe the solution you'd like
Replace the current code that uses https://.azuredatabricks.net/

Additional context
The current hostnames have not been deprecated (yet) so we have still time.

@sdebruyn sdebruyn added the feature New feature or request label May 4, 2020
@sdebruyn
Copy link
Contributor Author

sdebruyn commented May 4, 2020

Tracked in the azurerm provider in hashicorp/terraform-provider-azurerm#6732

@nfx
Copy link
Contributor

nfx commented May 4, 2020

@sdebruyn we'll look into this issue and see what we can do. this is not a complicated one.

@lawrencegripper
Copy link
Contributor

Created a PR here to add into AzureRM: hashicorp/terraform-provider-azurerm#6973

@stikkireddy
Copy link
Contributor

@lawrencegripper also noticed that in the existing code I actually can get the url with the GET request from the management API so, we may not need the workspace url fetched from the Azure RM client as the management api provides a url with the new format.

The following get request provides it:

https://management.azure.com/subscriptions/" + a.TokenPayload.SubscriptionID + "/resourceGroups/" + a.TokenPayload.ResourceGroup + "/providers/Microsoft.Databricks/workspaces/" + a.TokenPayload.WorkspaceName + "" +
		"?api-version=2018-04-01

@lawrencegripper
Copy link
Contributor

Ah nice work around, in good news the change is shipping now from azurerm so can be used shortly if that saves some effort hashicorp/terraform-provider-azurerm#6732

@stuartleeks
Copy link
Contributor

Just shipped 😀

https://github.com/terraform-providers/terraform-provider-azurerm/releases/tag/v2.11.0

@EliiseS
Copy link
Contributor

EliiseS commented Jun 17, 2020

I'll be picking up this with @lawrencegripper in an attempt that it'll fix #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure Occurring on Azure cloud feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants