You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Amend spark-perf to check if --skip-java-test exists in make-distribution. Something like:
...
withcd(target_dir):
logger.info("Building spark at version %s; This may take a while...\n"%commit_id)
# Spark version 1.5+ no longer uses the --skip-java-test flag in make-distribution.shskip_java_test_code=run_cmd('cat make-distribution.sh | grep "skip-java-test"', exit_on_fail=False)
skip_java_test_str="--skip-java-test"ifskip_java_test_code==0else""# According to the SPARK-1520 JIRA, building with Java 7+ will only cause problems when# running PySpark on YARN or when running on Java 6. Since we'll be building and running# Spark on the same machines and using standalone mode, it should be safe to# disable this warning:ifis_yarn_mode:
run_cmd("./make-distribution.sh %s -Pyarn %s"% (skip_java_test_str, additional_make_distribution_args))
else:
run_cmd("./make-distribution.sh %s %s"% (skip_java_test_str, additional_make_distribution_args))
...
Amend make-distribution.sh to give a warning such as suggested in the commit.
e.g.
echo"Warning: '--skip-java-test' is deprecated and has no effect.";;
I can submit a PR for option 1 or 2 as required, let me know which you prefer.
The text was updated successfully, but these errors were encountered:
Attempting to run spark-perf against master fails:
The issue is with the
--skip-java-test
flag, which was recently removed in apache/spark@6cf51a7. It's still used in Spark 1.4- (https://github.com/apache/spark/blob/branch-1.4/make-distribution.sh#L146)There are 2 potential fixes:
--skip-java-test
exists inmake-distribution
. Something like:make-distribution.sh
to give a warning such as suggested in the commit.e.g.
I can submit a PR for option 1 or 2 as required, let me know which you prefer.
The text was updated successfully, but these errors were encountered: