-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataFrame.to_clipboard & Series.to_clipboard #257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 93.57% 93.59% +0.01%
==========================================
Files 33 34 +1
Lines 3286 3325 +39
==========================================
+ Hits 3075 3112 +37
- Misses 211 213 +2
Continue to review full report at Codecov.
|
@rxin any idea why |
I think it's spurious failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do Series.to_clipboard
together while we're here?
@HyukjinKwon I added |
New tests in |
@@ -35,6 +35,16 @@ def to_html(self, max_rows=None, unsupported_param=None): | |||
}, index=[0, 1, 3]) | |||
validate_arguments_and_invoke_function(pdf, self.to_html, pd.DataFrame.to_html, args) | |||
|
|||
def to_clipboard(self, sep=',', **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this test case here? this file is for testing functionalities in utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case is for testing **kwargs
in validate_arguments_and_invoke_function()
Improve validate_arguments_and_invoke_function() when receiving argument **kwargs
- actual args : {'kwargs': {'index': False}, 'sep': ',', 'excel': True}
- expected args : {'sep': ',', 'excel': True, 'index': False}
whoa .. merging others made some conflicts here.. |
@HyukjinKwon done! |
I'll solve the conflict! |
cc @HyukjinKwon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Let me double check and get this in today.
Add `DataFrame.to_clipboard` and `Series.to_clipboard`. Part of databricks#169. Improve `validate_arguments_and_invoke_function()` when receiving argument `**kwargs` + actual args : `{'kwargs': {'index': False}, 'sep': ',', 'excel': True}` + expected args : `{'sep': ',', 'excel': True, 'index': False}`
Add
DataFrame.to_clipboard
andSeries.to_clipboard
. Part of #169.Improve
validate_arguments_and_invoke_function()
when receiving argument**kwargs
{'kwargs': {'index': False}, 'sep': ',', 'excel': True}
{'sep': ',', 'excel': True, 'index': False}