Improve: build snapshot in anohter task #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, snapshot is built in the `sm::Worker`, which blocks other state-machine writes, such as applying log entries. This commit parallels applying log entries and building snapshot: A snapshot is built in another `tokio::task`. Because building snapshot is a read operation, it does not have to block the entire state machine. Instead, it only needs a consistent view of the state machine or holding a lock of the state machine. - Fix: databendlabs#596
drmingdrmer
force-pushed
the
24-parallel-build-snapshot
branch
from
1c2b2c1
to
fa4085b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Improve: build snapshot in anohter task
Before this commit, snapshot is built in the
sm::Worker, which blocksother state-machine writes, such as applying log entries.
This commit parallels applying log entries and building snapshot: A
snapshot is built in another
tokio::task.Because building snapshot is a read operation, it does not have to
block the entire state machine. Instead, it only needs a consistent view
of the state machine or holding a lock of the state machine.
Chore: add check.kdl to run local check in parallel
This change is