Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an option SnapshotPolicy::Never #851

Closed
drmingdrmer opened this issue May 23, 2023 · 1 comment · Fixed by #854
Closed

add an option SnapshotPolicy::Never #851

drmingdrmer opened this issue May 23, 2023 · 1 comment · Fixed by #854

Comments

@drmingdrmer
Copy link
Member

drmingdrmer commented May 23, 2023 •
edited
Loading

Add an option SnapshotPolicy::Never for application that wish to control snapshot building manually.

In such a scenario, use Raft::trigger_snapshot() to trigger snapshot building.

Originally posted by @drmingdrmer in #823 (comment)
@github-actions
Copy link

👋 Thanks for opening this issue!

Get help or engage by:

  • /help : to print help messages.
  • /assignme : to assign this issue to you.

@drmingdrmer drmingdrmer changed the title add an option SnapshotPolicy::Never add an option SnapshotPolicy::Never and SnapshotPolicy::Manual May 23, 2023
@drmingdrmer drmingdrmer changed the title add an option SnapshotPolicy::Never and SnapshotPolicy::Manual add an option SnapshotPolicy::Never May 24, 2023
@drmingdrmer drmingdrmer mentioned this issue May 24, 2023
Merged
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue May 24, 2023
@drmingdrmer
Feature: add SnapshotPolicy::Never
b19464c 
With `SnapshotPolicy::Never`, Openraft will not build snapshots
automatically based on a policy. Instead, the application has full
control over when snapshots are built. In this scenario, the application
can call the `Raft::trigger_snapshot()` API at the desired times to
manually trigger Openraft to build a snapshot.

Rename integration tests:
- `log_compaction -> snapshot_building`
- `snapshto -> snapshot_streaming`

-  Fix: databendlabs#851
drmingdrmer added a commit to drmingdrmer/openraft that referenced this issue May 24, 2023
@drmingdrmer
Feature: add SnapshotPolicy::Never
269d221 
With `SnapshotPolicy::Never`, Openraft will not build snapshots
automatically based on a policy. Instead, the application has full
control over when snapshots are built. In this scenario, the application
can call the `Raft::trigger_snapshot()` API at the desired times to
manually trigger Openraft to build a snapshot.

Rename integration tests:
- `log_compaction -> snapshot_building`
- `snapshto -> snapshot_streaming`

-  Fix: databendlabs#851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: add SnapshotPolicy::Never drmingdrmer/openraft
1 participant
@drmingdrmer