Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CREATE CATALOG #8252

Closed
Tracked by #7592
BohuTANG opened this issue Oct 17, 2022 · 6 comments · Fixed by #8255
Closed
Tracked by #7592

feat: CREATE CATALOG #8252

BohuTANG opened this issue Oct 17, 2022 · 6 comments · Fixed by #8255
Labels
C-feature Category: feature

Comments

@BohuTANG
Copy link
Member

    > If so, we can do it as a hive table in databend: new catalog and new table engine.

Using a catalog in hive way is not good for me. We should allow users use to configure the catalog for the iceberg. For example, specify the iceberg location by SQL instead of static config.

In this way, we need to introduce a create catalog like:

CREATE CATALOG my_icerberg TYPE='iceberg' CONNECTION=(URL='s3://my_bucket')
SELECT * from my_iceberg.db.table;

Originally posted by @Xuanwo in #8215 (comment)

@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2022

cc @sandflee for comments.

@BohuTANG
Copy link
Member Author

I am not sure what the statement on the hive table to replace the static config, could you give an example? @dantengsky @Xuanwo

@Xuanwo

This comment was marked as off-topic.

@BohuTANG BohuTANG added the C-feature Category: feature label Oct 17, 2022
@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2022

I am not sure what the statement on the hive table to replace the static config, could you give an example? @dantengsky @Xuanwo

The config in databend-query for hive only have two fields:

#[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize, Args)]
#[serde(default)]
pub struct HiveCatalogConfig {
    #[clap(long = "hive-meta-store-address", default_value = "127.0.0.1:9083")]
    pub meta_store_address: String,
    #[clap(long = "hive-thrift-protocol", default_value = "binary")]
    pub protocol: String,
}

we can replace it by:

CREATE CATALOG my_hive
  TYPE='hive'
  CONNECTION = (URL='<hive-meta-store>' THRIFT_PROTOCOL=BINARY);
SELECT * FROM my_hive.db.table;

@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2022

We can defer the hive support after we confirm that it works well on the iceberg.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 17, 2022

I'm working on an RFC for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants