Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metasrv] Refactor metasrv errors #4000

Closed
ariesdevil opened this issue Jan 26, 2022 · 1 comment
Closed

[metasrv] Refactor metasrv errors #4000

ariesdevil opened this issue Jan 26, 2022 · 1 comment
Assignees
Labels
A-meta Area: databend meta serive C-improvement Category: improvement C-refactoring Category: refactor

Comments

@ariesdevil
Copy link
Collaborator

Now we use ErrorCode as the error return type for most of metasrv's functions, but this makes it difficult to get the underlying error, and we would like to remove ErrorCode and only wrap it to ErrorCode when it is returned to the query side.

  • use thiserror defines some concrete error type with a MetaError for including these error types just like ErrorCode.
  • handle the type conversion, convert to other error types only when necessary
  • tests
@lichuang
Copy link
Contributor

#4023

#4090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: databend meta serive C-improvement Category: improvement C-refactoring Category: refactor
Projects
None yet
Development

No branches or pull requests

2 participants