Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http_handler): the first request no longer wait for query to start #7410

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Aug 31, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

  1. feat(http_handler): the first request no longer wait for query to start.
    1. start query in the runtime of query context, and then polling for page just like the following request. the starting of query may involve read and prune( with bloom filter) partitions
    2. add a state of STARTING, only internal for now
  2. never clear expire time.
    1. because the handler future may be dropped without notice. Server: Provide a closed connection notification hyperium/hyper#707
    2. base on the previous commit: all request (including the first) should return in more than wait_time_secs

Fixes databendlabs/databend-perf#106

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 5:33AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Aug 31, 2022
@youngsofun youngsofun marked this pull request as draft August 31, 2022 03:26
1. start query in the runtime of query context, and then polling for page just like the following request.
2. add a state of STARTING, only internal for now
1. because the handler future may be dropped without notice.
2. base on the previous commit: all request (including the first) should return in more than wait_time_secs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
3 participants