Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this library or a tool? #232

Closed
kgrvamsi opened this issue Oct 4, 2021 · 2 comments
Closed

Is this library or a tool? #232

kgrvamsi opened this issue Oct 4, 2021 · 2 comments
Labels
planned

Comments

@kgrvamsi
Copy link

kgrvamsi commented Oct 4, 2021

Hello @ajthinking

Love this tool on how it works and would like to know if this can be used as library in an existing react project.
@ajthinking
Copy link
Contributor

Hi @kgrvamsi, thanks for reaching out.
While that is the goal, it is not quite ready to be used as a lib just yet. At the moment it needs its own tag <div id="app"> and the js-bundle to render to that tag. But I think we should be able to setup exports of a <DataStory> react component, which would make it possible to use inside existing apps shortly 👍

@ajthinking ajthinking mentioned this issue Oct 27, 2021
Merged
@ajthinking
Copy link
Contributor

To some degree, fixed in #256. Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgrvamsi @ajthinking