Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have dataframe-api as a submodule #6

Open
honno opened this issue Jun 22, 2022 · 1 comment
Open

Have dataframe-api as a submodule #6

honno opened this issue Jun 22, 2022 · 1 comment

Comments

@honno
Copy link
Member

honno commented Jun 22, 2022

Right now we manually vendor in the dataframe interchange pipeline, which originally live in https://github.com/data-apis/dataframe-api. Ideally we'd instead have that repo as a submodule, as we can effectively pin what we're working with and get updates as they come. Unfortunately the spec doesn't quite work as code due to missing imports and other minor typing problems.

So once I'm more happy with the API-as-importable-code situation, I'll submit an appropriate PR to dataframe-api repo, I should be able to drop tests/api.py in favour of a dynamically imported API.

EDIT: might be we can just wait for data-apis/dataframe-api#74 to merge

@honno
Copy link
Member Author

honno commented Aug 8, 2022

Not a simple import as from future import __annotations__ is required for some stuff to work with py3.8/py3.9, which we want to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant