Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vendoring this test suite by removing need for array-api submodule #107

Open
honno opened this issue Mar 22, 2022 · 1 comment
Open
Labels
medium priority Medium priority issue

Comments

@honno
Copy link
Member

honno commented Mar 22, 2022

In #104 we introduce a git submodule of the array-api repo, which going forward is required for the test suite to function (e.g. special case tests). This is not ideal for some vendoring use cases where array libraries such as NumPy might like to ship the test suite in their own repo, and a git submodule would be a big nuisance to that end.

There are two current options I see:

  1. Hard code the signatures files ala the ones we generated with generate_stubs.py. A pre-commit hook could alleviate the pain somewhat of having an out-of-sync repo, which was a common problem before.
  2. Allow the user to specify somewhere (variable? env? package?) where the signatures folder/package is, so someone vendoring can vendor the spec too and use that.
@honno
Copy link
Member Author

honno commented Sep 30, 2022

Relevant data-apis/array-api#488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium priority Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants
@honno and others