Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include type in failed sizeof warning #8580

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

jrbourbeau
Copy link
Member

@jrbourbeau jrbourbeau commented Mar 13, 2024

Including this information will help when debugging failing sizeof calls.

xref #8578

EDIT: Actually, this isn't that useful in the specific case I'm looking at (the type is dict), but still could be nice to add

@jrbourbeau jrbourbeau requested a review from fjetter as a code owner March 13, 2024 20:12
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   10h 17m 31s ⏱️ + 3m 31s
 4 055 tests ± 0   3 946 ✅ + 2    109 💤 ±0  0 ❌  - 2 
50 872 runs  +18  48 559 ✅ +28  2 313 💤  - 7  0 ❌  - 3 

Results for commit 9cb5fa6. ± Comparison against base commit 29cb664.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@milesgranger milesgranger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change for the good, thanks @jrbourbeau!

@jrbourbeau
Copy link
Member Author

Thanks @milesgranger

@jrbourbeau jrbourbeau merged commit 8c93366 into dask:main Mar 15, 2024
34 checks passed
@jrbourbeau jrbourbeau deleted the type-sizeof-warning branch March 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants