Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indicator support to merge #8539

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

phofl
Copy link
Collaborator

@phofl phofl commented Feb 27, 2024

Closes #8527

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ± 0      27 suites  ±0   9h 59m 30s ⏱️ + 4m 47s
 3 997 tests + 1   3 882 ✅  - 2    110 💤 ±0  5 ❌ +3 
50 265 runs  +11  47 965 ✅ +8  2 295 💤 ±0  5 ❌ +3 

For more details on these failures, see this check.

Results for commit 591bc5b. ± Comparison against base commit 84e7c4d.

Copy link
Member

@hendrikmakait hendrikmakait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phofl!

@hendrikmakait hendrikmakait merged commit f86a031 into dask:main Feb 28, 2024
29 of 35 checks passed
@phofl phofl deleted the indicator_merge branch February 29, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing merge indicator column causes KeyError with shuffle.method = p2p
2 participants