Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_restart_during_computation flaky #4956

Closed
gjoseph92 opened this issue Jun 22, 2021 · 1 comment
Closed

test_restart_during_computation flaky #4956

gjoseph92 opened this issue Jun 22, 2021 · 1 comment
Labels
flaky test Intermittent failures on CI.

Comments

@gjoseph92
Copy link
Collaborator

On Windows, 3.8: https://github.com/dask/distributed/pull/4925/checks?check_run_id=2888102603#step:10:2445

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

check = True

    @contextmanager
    def check_process_leak(check=True):
        for proc in mp_context.active_children():
            proc.terminate()
    
        yield
    
        if check:
            for i in range(200):
                if not set(mp_context.active_children()):
                    break
                else:
                    sleep(0.2)
            else:
>               assert not mp_context.active_children()
E               AssertionError: assert not [<Process name='Dask Worker process (from Nanny)' pid=5616 parent=2984 started daemon>]
E                +  where [<Process name='Dask Worker process (from Nanny)' pid=5616 parent=2984 started daemon>] = <function active_children at 0x000001CC8C16BE50>()
E                +    where <function active_children at 0x000001CC8C16BE50> = mp_context.active_children

distributed\utils_test.py:1472: AssertionError
@fjetter fjetter added the flaky test Intermittent failures on CI. label Jun 23, 2021
@fjetter fjetter mentioned this issue Feb 16, 2022
51 tasks
@hendrikmakait
Copy link
Member

test_restart_during_computation has not appeared as a flaking test on the test report for the last 50 workflows, so this seems to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

No branches or pull requests

3 participants