Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test teardown in check_thread_leak #4740

Closed
fjetter opened this issue Apr 23, 2021 · 0 comments · Fixed by #4747
Closed

Flaky test teardown in check_thread_leak #4740

fjetter opened this issue Apr 23, 2021 · 0 comments · Fixed by #4747
Labels
flaky test Intermittent failures on CI.

Comments

@fjetter
Copy link
Member

fjetter commented Apr 23, 2021

E.g. https://github.com/fjetter/distributed/runs/2411704392?check_suite_focus=true

______ ERROR at teardown of test_nanny_closed_by_keyboard_interrupt[tcp] _______

    @pytest.fixture
    def cleanup():
        with clean():
>           yield

distributed/utils_test.py:1552: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/share/miniconda3/envs/dask-distributed/lib/python3.7/contextlib.py:119: in __exit__
    next(self.gen)
distributed/utils_test.py:1546: in clean
    del thread_state.on_event_loop_thread
/usr/share/miniconda3/envs/dask-distributed/lib/python3.7/contextlib.py:119: in __exit__
    next(self.gen)
distributed/utils_test.py:1428: in check_thread_leak
    for t, v in threading._active.items()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

.0 = <dict_itemiterator object at 0x7f5364277d70>

>       t
        for t, v in threading._active.items()
        if t not in active_threads_start
        and "Threaded" not in v.name
        and "watch message" not in v.name
        and "TCP-Executor" not in v.name
        # TODO: Make sure profile thread is cleaned up
        # and remove the line below
        and "Profile" not in v.name
    ]
E   RuntimeError: dictionary changed size during iteration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky test Intermittent failures on CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant