From 38601226ee7ca43808d72b40831bb92be4d3e0a9 Mon Sep 17 00:00:00 2001 From: Matthew Rocklin Date: Thu, 26 May 2022 11:15:25 -0500 Subject: [PATCH] verify logging output --- distributed/tests/test_preload.py | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/distributed/tests/test_preload.py b/distributed/tests/test_preload.py index 7a4185f762..04bec1cb95 100644 --- a/distributed/tests/test_preload.py +++ b/distributed/tests/test_preload.py @@ -1,3 +1,4 @@ +import logging import os import re import shutil @@ -281,6 +282,23 @@ def dask_setup(client, value): assert c.foo == value +@gen_test() +async def test_teardown_failure_doesnt_crash_scheduler(): + text = """ +def dask_teardown(worker): + raise Exception(123) +""" + + with captured_logger(logging.getLogger("distributed.scheduler")) as s_logger: + with captured_logger(logging.getLogger("distributed.worker")) as w_logger: + async with Scheduler(dashboard_address=":0", preload=text) as s: + async with Worker(s.address, preload=[text]) as w: + pass + + assert "123" in s_logger.getvalue() + assert "123" in w_logger.getvalue() + + @gen_cluster(nthreads=[]) async def test_client_preload_config_click(s): text = dedent( @@ -302,14 +320,3 @@ def dask_setup(client, value): ): async with Client(address=s.address, asynchronous=True) as c: assert c.foo == value - - -@gen_test() -async def test_teardown_failure_doesnt_crash_scheduler(): - text = """ -def dask_teardown(worker): - raise Exception(123) -""" - async with Scheduler(dashboard_address=":0", preload=text) as s: - async with Worker(s.address, preload=[text]) as w: - pass