Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bincount fix slicing #7391

Merged
merged 10 commits into from
Mar 18, 2021
Merged

Bincount fix slicing #7391

merged 10 commits into from
Mar 18, 2021

Commits on Mar 15, 2021

  1. Fix bincount slicing error found in scikit-image, cupy, and dask-ml

    @GenevieveBuckley
    GenevieveBuckley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ea6cbe2 View commit details
    Browse the repository at this point in the history

  2. Test bincount has expected shape and chunks

    @GenevieveBuckley
    GenevieveBuckley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    1b42445 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into bincount-fix-slicing

    @GenevieveBuckley
    GenevieveBuckley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    b31d606 View commit details
    Browse the repository at this point in the history

  4. Explicit test we can slice the output of bincount

    @GenevieveBuckley
    GenevieveBuckley committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    5562b7e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Preserve meta array type (for cupy input, etc)

    @GenevieveBuckley
    GenevieveBuckley committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    6bf5340 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. Use array_safe instead of np.array like= kwarg so we don't break test… 

    …s using older versions of numpy
    @GenevieveBuckley
    GenevieveBuckley committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    c162438 View commit details
    Browse the repository at this point in the history

  2. Skip cupy test if numpy is <1.20, since NEP-35 is required

    @GenevieveBuckley
    GenevieveBuckley committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    1ed7819 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2021

  1. Update dask/array/tests/test_routines.py 

    Co-authored-by: James Bourbeau <[email protected]>
    @GenevieveBuckley @jrbourbeau
    GenevieveBuckley and jrbourbeau authored Mar 18, 2021
    Configuration menu
    Copy the full SHA
    82c9c0a View commit details
    Browse the repository at this point in the history

  2. James' suggestions to simplify logic

    @GenevieveBuckley
    GenevieveBuckley committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    2e12451 View commit details
    Browse the repository at this point in the history

  3. Make meta robust if a non-dask array is passed

    @GenevieveBuckley
    GenevieveBuckley committed Mar 18, 2021
    Configuration menu
    Copy the full SHA
    0c67526 View commit details
    Browse the repository at this point in the history