Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dashboard/--no-dashboard flag and enable by default #127

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Jun 27, 2024

Closes #126

Currently when running dask-mpi the dashboard is disabled unless you set the --dashboard-address flag to some value.

# Old behaviour

# Dashboard disabled (the default)
mpirun -np $SLURM_NTASKS dask-mpi --scheduler-file scheduler.json

# Dashboard enabled
mpirun -np $SLURM_NTASKS dask-mpi --scheduler-file scheduler.json --dashboard-address :8787

In the dask scheduler CLI there is a flag to enable/disable the dashboard and it defaults to enabled. This PR adds the same --dashboard/--no-dashboard flag to the dask-mpi CLI and also sets the default as enabled.

# New behaviour

# Dashboard enabled (the default)
mpirun -np $SLURM_NTASKS dask-mpi --scheduler-file scheduler.json

# Dashboard disabled
mpirun -np $SLURM_NTASKS dask-mpi --scheduler-file scheduler.json --no-dashboard

Copy link
Collaborator

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks, @jacobtomlinson

@kmpaul
Copy link
Collaborator

kmpaul commented Jul 2, 2024

Don't know why ReadTheDocs doesn't install a more recent version of Sphinx than 4.5, but that's why the docs are failing to build. I'm going to merge this and fix the docs error later.

@kmpaul kmpaul merged commit 0ab8177 into dask:main Jul 2, 2024
6 of 7 checks passed
@kmpaul
Copy link
Collaborator

kmpaul commented Jul 2, 2024

Incidentally, the RTD build errors can be fixed with the amendments to the pip section of the docs/environment.yaml conda env file, as mentioned in dask/dask-sphinx-theme#68. I've implemented the local mods in the rank-replacement branch.

@jacobtomlinson jacobtomlinson deleted the dashboard-on-by-default branch July 3, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard returns 404 error in Dask-MPI
2 participants