You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Dask operator has a number of Custom Resource Definitions. Many of these definitions have specs from other resources nested within them. For example the scheduler and worker parameters within DaskCluster have nested PodSpec specifications because these will ultimately be created as Pods by the controller.
I'm conscious that k8s-crd-resolver appears to be unmaintained and has not had new schema definitions introduced since Kubernetes 1.25 which went EOL in October 2023. I also opened elemental-lf/k8s-crd-resolver#6 over a year ago which has not had any response.
It could be interesting to explore migrating the CRD generation to Python Dataclasses instead of YAML templates. There is a library that can do this called kubecrd but this also appears to be unmaintained. It also does not support having multiple version schemas and so would stop us from impementing #753.
As a response to this I'm exploring generating Custom Resource Definition objects in kr8s from dataclasses (kr8s-org/kr8s#456). Putting this code in kr8s will help ensure it is tested and maintained. It would also allow you to create multiple dataclasses, one for each version of the schema.
The text was updated successfully, but these errors were encountered:
The Dask operator has a number of Custom Resource Definitions. Many of these definitions have specs from other resources nested within them. For example the
scheduler
andworker
parameters withinDaskCluster
have nestedPodSpec
specifications because these will ultimately be created as Pods by the controller.dask-kubernetes/dask_kubernetes/operator/customresources/templates.yaml
Line 36 in 734d001
To generate the Custom Resource Definitions that we ship in the Dask Kubernetes Operator Helm Chart we have a whole pile of yaml that contains the definition templates. Then we have a
pre-commit
hook that runsk8s-crd-resolver
which renders the templates into the helm chart crds directory.I'm conscious that
k8s-crd-resolver
appears to be unmaintained and has not had new schema definitions introduced since Kubernetes1.25
which went EOL in October 2023. I also opened elemental-lf/k8s-crd-resolver#6 over a year ago which has not had any response.It could be interesting to explore migrating the CRD generation to Python Dataclasses instead of YAML templates. There is a library that can do this called
kubecrd
but this also appears to be unmaintained. It also does not support having multiple version schemas and so would stop us from impementing #753.As a response to this I'm exploring generating Custom Resource Definition objects in
kr8s
from dataclasses (kr8s-org/kr8s#456). Putting this code inkr8s
will help ensure it is tested and maintained. It would also allow you to create multiple dataclasses, one for each version of the schema.The text was updated successfully, but these errors were encountered: