Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.4.1 #371

Closed
4 tasks
jrbourbeau opened this issue Apr 3, 2024 · 12 comments
Closed
4 tasks

Release 2024.4.1 #371

jrbourbeau opened this issue Apr 3, 2024 · 12 comments
Labels

Comments

@jrbourbeau
Copy link
Member

jrbourbeau commented Apr 3, 2024

Release version 2024.4.1
Planned release date 2024-04-04
Status On-track
Release manager @jrbourbeau

Best effort

Try to close before the release but will not block the release

  • ...
  • ...

Blocker

Issues that would cause us to block and postpone the release if not fixed

  • ...
  • ...

Comments

The 2024.4.0 release, import dask.dataframe raises an error on Python 3.11.9 (other Python versions are okay) dask/dask#11035. Things have been fixed on main and I'd like to push out a new release later today with the fix.

cc @fjetter @phofl @rjzamora @quasiben @hendrikmakait @crusaderky

@rjzamora
Copy link
Member

rjzamora commented Apr 3, 2024

Just a note that dask/dask#11035 may not have correctly resolved the problem. We are now seeing <function PandasDelegate._add_delegate_accessors.<locals>._create_delegator_method.<locals>.f at 0x7f0ecacbf560> - Will try to follow up soon.

@jrbourbeau
Copy link
Member Author

Thanks for the heads up @rjzamora. I'll hold off on releasing until we're sure things have been resolved.

@rjzamora
Copy link
Member

rjzamora commented Apr 4, 2024

Okay - It looks like the problem I reported above was likely due to a corrupted environment. Someone internal reported that they were hitting this new TypeError. However, they are no longer able to reproduce the problem after a fresh build. We could always remove the new TypeError to be safe, but I'm not sure it's necessary.

@phofl
Copy link

phofl commented Apr 4, 2024

We got the same report from someone else dask/dask#11038

cc @rjzamora so I think the failure was legit?

@rjzamora
Copy link
Member

rjzamora commented Apr 4, 2024

@phofl - Yes, the DatetimeAccessor error was very real. We were also seeing a PandasDelegate error after 11035 was merged, but it seems to have been a local environment problem.

@jrbourbeau
Copy link
Member Author

Okay, so sounds like dask/dask#11035 is needed and there's not a known related follow up needed either. I'll wait a bit for further feedback and then will start pushing this release out

@rjzamora
Copy link
Member

rjzamora commented Apr 4, 2024

@jrbourbeau - I submitted dask/dask#11039 to make sure we don't run into the hypothetical problem I mentioned. Feel free to ignore, but might be worth merging first.

@rjzamora
Copy link
Member

rjzamora commented Apr 4, 2024

On a related note: I wonder how many users/organizations are temporarily stuck on 2024.1.1 until they have had time to migrate to the new dask-expr API?

For the impending rapids 24.04 release, we are pouring many engineering hours into finding a way to patch/vendor our own version of dask-2024.1.1 with the python 3.10 fix. We originally considered this to be our own problem to deal with. However, I now strongly suspect that many other organizations would benefit from a patched 2024.1.1 release. Any thoughts on this?

@jrbourbeau
Copy link
Member Author

FYI 2024.4.1 is out on PyPI (conda-forge + docker soon)

@jrbourbeau
Copy link
Member Author

FYI it appears there were some CDN issues with conda-forge today and dask-core=2024.4.1 still isn't available to download (cc @jakirkham in case I'm misunderstanding). I'll try bumping the remaining feedstocks tomorrow

@jrbourbeau
Copy link
Member Author

Closing as 2024.4.1 is out on conda-forge and docker registries now

On a related note: I wonder how many users/organizations are temporarily stuck on 2024.1.1 until they have had time to migrate to the new dask-expr API?

@phofl probably has a better sense than I do for this. I've mostly seen folks turning query planning off who run into issues for one reason or another (though issues have been quickly resolved in dask-expr too)

Maybe @quasiben @charlesbluca can do something similar to #316 to help. Regardless, this seems like a separate issue, so I'm going to close this issue out (hope that's okay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants