Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2021.03.0 #129

Closed
jrbourbeau opened this issue Feb 23, 2021 · 19 comments
Closed

Release 2021.03.0 #129

jrbourbeau opened this issue Feb 23, 2021 · 19 comments

Comments

@jrbourbeau
Copy link
Member

It's been a few weeks since the last release. I'd like to release Dask and Distributed version 2021.02.1 this Friday if others are okay with it

cc @jakirkham @kkraus14 @jsignell

@kkraus14
Copy link
Member

We're seeing a flaky incorrect result from dask.dataframe.describe in dask-cudf unit tests that seems to be a cupy bug, but we're still triaging. Hopefully should have more clarity in the next couple of days, but as of now no objections.

@jrbourbeau
Copy link
Member Author

Thanks for the heads up @kkraus14 👍

@jrbourbeau
Copy link
Member Author

@jsignell
Copy link
Member

It'd be good to fix or revert dataframe __setitem__: dask/dask#7261

@jakirkham
Copy link
Member

We're seeing a flaky incorrect result from dask.dataframe.describe in dask-cudf unit tests that seems to be a cupy bug, but we're still triaging. Hopefully should have more clarity in the next couple of days, but as of now no objections.

For context there seem to be two things. A CuPy bug ( cupy/cupy#4451 ), which will be fixed in CuPy 9 and we are working to backport to CuPy 8 ( cupy/cupy#4742 ). A Dask-cuDF bug ( rapidsai/cudf#7402 ), which is still being investigated.

@jrbourbeau
Copy link
Member Author

Thanks for the update @jakirkham -- it sounds like there's nothing for us to do about these issues on the dask / distributed side of things.

There are a few issues, specifically dask/dask#7263, dask/distributed#4538, and dask/dask#7261, that might cause friction with releasing tomorrow. Perhaps this is a good time to push releasing back a week to give time to resolve these lingering issues. Do others have any objections to releasing next Friday instead of tomorrow?

@jakirkham
Copy link
Member

Correct

Followed up with Florian in issue ( dask/distributed#4538 ), but it sounds like he can’t reproduce the error. Given this, not sure what else there is to do there

@jrbourbeau
Copy link
Member Author

Followed up with Florian in issue ( dask/distributed#4538 ), but it sounds like he can’t reproduce the error

Awesome, thanks for staying on top of that issue! Yeah, I agree if we can't reproduce the issue then there's not much we can do about it.

For dask/dask#7261 we could, as @jsignell suggested, revert the setitem changes in dask/dask#7033. However I get the sense we still need to form consensus on dask/dask#7263

@jakirkham
Copy link
Member

jakirkham commented Feb 26, 2021

Thanks for keeping track of all of things James! 😄

Got it. So issue ( dask/dask#7263 ) is the tricky one. Read through it and agree we should fix that before we release, but don't have any concrete suggestions. Pushing out the release date to next week makes sense.

@jsignell
Copy link
Member

jsignell commented Feb 26, 2021

It'd be good to get this one in as well dask/dask#7260

@jakirkham
Copy link
Member

How are things looking? Curious as we were planning on releasing this coming Friday

@jrbourbeau
Copy link
Member Author

Here's the current status:

@jakirkham
Copy link
Member

Thank you for tracking these James! 😄

@jakirkham
Copy link
Member

We just stumbled across an issue on CI in RAPIDS that tracks back to a recent Dask change. Please see this comment for details ( dask/dask#7305 (comment) ). Thanks @rjzamora for identifying this!

@jakirkham
Copy link
Member

The issue Rick identified is being addressed by Peter in PR ( dask/dask#7325 )

@jakirkham
Copy link
Member

Ok I think we have all the release blocker fixes in. Though please recheck.

Just went back through James' list and all the patches have been merged. We also fixed the issue Rick identified.

We have not been able to reproduce issue ( dask/distributed#4538 ). So that has been ignored for now.

@jrbourbeau
Copy link
Member Author

Yep, all the blocker fixes are in. Thanks everyone who's been working on them!

There's one last loose end to tie up before releasing -- we need to bump the minimum version of distributed over in dask. @jakirkham would you mind taking a quick look at dask/dask#7328 which does this

@jakirkham
Copy link
Member

Good point. Thanks for remembering that. Reviewed 😀

@jrbourbeau
Copy link
Member Author

Thanks all! 2021.03.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants