Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): tune channel priorities and move channel definitions to p2p/channel_params.go #759

Merged
merged 16 commits into from
Mar 12, 2024

Conversation

lklimek
Copy link
Collaborator

@lklimek lklimek commented Mar 12, 2024

Issue being fixed or feature implemented

Channel definitions are spread across the code, making it quite hard to maintain.

What was done?

Moved all channel definitions to p2p/channel_params.go

Tuned channel priorities to give lower prio to mempool and higher to consensus

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@lklimek lklimek changed the base branch from v0.10-dev to v0.14-dev March 12, 2024 09:31
@lklimek lklimek requested a review from shumkov as a code owner March 12, 2024 09:31
@lklimek lklimek changed the base branch from v0.14-dev to feat/rate-limiting-channels March 12, 2024 09:32
@lklimek lklimek changed the title refactor(p2p): move channel definitions to p2p/channel_params.go refactor(p2p): tune channel priorities and move channel definitions to p2p/channel_params.go Mar 12, 2024
shumkov
shumkov previously approved these changes Mar 12, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from feat/rate-limiting-channels to v0.14-dev March 12, 2024 15:52
@lklimek lklimek dismissed shumkov’s stale review March 12, 2024 15:52

The base branch was changed.

@lklimek lklimek enabled auto-merge (squash) March 12, 2024 15:54
@lklimek lklimek requested a review from shumkov March 12, 2024 15:54
@lklimek lklimek merged commit 9028d25 into v0.14-dev Mar 12, 2024
15 checks passed
@lklimek lklimek deleted the refactor/move-channel-definitions branch March 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants