ci: docker image always released as -dev #2358
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflows for building and pushing Docker images. It introduces a new input parameter, Changes
Possibly related PRs
Suggested reviewers
Poem
Warning Rate limit exceeded@lklimek has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 22 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Dockerfile (1)
326-329: Consider adding a comment to document the profile usage.The implementation correctly uses the build profile across all stages. Consider adding a brief comment explaining the impact of this argument on the build process.
# Select whether we want dev or release ONBUILD ARG CARGO_BUILD_PROFILE=dev +# CARGO_BUILD_PROFILE affects: +# - Build configuration (debug/release) +# - Output directory selection +# - Feature flags (console,grovedbg in dev)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🔇 Additional comments (1)
Dockerfile (1)
326-329: LGTM! The ONBUILD ARG implementation looks good.
The implementation correctly allows for dynamic selection of the Cargo build profile, defaulting to 'dev'. This change enables proper tagging of Docker images based on the build profile.
Let's verify the profile usage in build stages:
✅ Verification successful
The CARGO_BUILD_PROFILE implementation is correctly used throughout the build process
The verification confirms that:
- The profile is consistently used in cargo build commands with
--profile "${CARGO_BUILD_PROFILE}" - Proper conditional logic handles release vs dev profiles:
- Release mode: Uses config-release.toml and sets appropriate output directory
- Dev mode: Adds debug features (console, grovedbg)
- The profile setting propagates to the wasm-dpp build script with correct profile mapping
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that CARGO_BUILD_PROFILE is used consistently across build stages
# Check for profile usage in build commands
rg -A 3 'CARGO_BUILD_PROFILE|cargo (build|chef).*--profile'
# Check for conditional logic based on profile
rg -A 3 '\[\[ .*CARGO_BUILD_PROFILE.* \]\]'
Length of output: 2725
Issue being fixed or feature implemented
Due to some bug, docker images are always released as
dev, notreleaseWhat was done?
Restored missing line
How Has This Been Tested?
GHA pipeline executed
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
cargo_profilefor specifying the Cargo build profile during Docker image builds.cache_to_namefor improved caching during Docker image builds when a release is triggered.