-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run devcontainers workflow only on push to master #2295
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow configuration for prebuilding development containers. It updates the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1).github/workflows/prebuild-devcontainers.yml (1)
The change correctly restricts the workflow to run only on pushes to the master branch while maintaining the path filters. This optimization will help reduce unnecessary workflow executions. Let's verify that this is the only workflow building devcontainers and that we're not missing similar optimizations in related workflows: ✅ Verification successfulBranch restriction is correctly implemented and no other workflows are affected The verification confirms that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for other workflows that might be building devcontainers
# or using similar path triggers that could benefit from branch restrictions
# Search for workflows with devcontainer-related paths or jobs
rg -l --type yaml 'devcontainer|\.devcontainer' .github/workflows/
# Search for workflows with similar path-based triggers that might need branch restrictions
rg -A 5 'on:\s*\n\s*push:\s*\n\s*paths:' .github/workflows/
Length of output: 367 Script: #!/bin/bash
# Let's fix the regex and try again with proper multiline support
# Search for workflows with devcontainer-related paths or jobs
echo "=== Devcontainer-related workflows ==="
rg -l --type yaml 'devcontainer|\.devcontainer' .github/workflows/
# Search for workflows with path-based triggers using multiline mode
echo -e "\n=== Workflows with path-based triggers ==="
rg -U -A 5 '^on:[\s\n]+push:[\s\n]+paths:' .github/workflows/
Length of output: 891 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue being fixed or feature implemented
Currently, a long devcontainers worflow is running in case if related files are changed on push to any branch
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
master
branch only.