Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return consensus errors instead of transport errors in SDK #2273

Closed
shumkov opened this issue Oct 24, 2024 · 0 comments · Fixed by #2274
Closed

Return consensus errors instead of transport errors in SDK #2273

shumkov opened this issue Oct 24, 2024 · 0 comments · Fixed by #2274
Assignees
@shumkov
Labels
enhancement New feature or request

Comments

@shumkov
Copy link
Member

shumkov commented Oct 24, 2024

Expected Behavior

Users expect to see consensus errors in case if ST validation failed

Current Behavior

We return DAPI Client transport error

Possible Solution

Handle and deseriaise consenuss error from code and bytes

Alternatives Considered

Additional Context
@shumkov shumkov added the enhancement New feature or request label Oct 24, 2024
@shumkov shumkov moved this to In Progress in Platform team Oct 24, 2024
@shumkov shumkov self-assigned this Oct 24, 2024
@shumkov shumkov linked a pull request Oct 25, 2024 that will close this issue
feat(sdk)!: return consensus errors from broadcast methods #2274
Merged
6 tasks
@shumkov shumkov mentioned this issue Oct 25, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In review / testing to Done in Platform team Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shumkov shumkov

Labels
enhancement New feature or request
Projects
Platform team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk)!: return consensus errors from broadcast methods dashpay/platform
1 participant
@shumkov