Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tx status if it's already in cache while broadcasting #2268

Open
shumkov opened this issue Oct 22, 2024 · 0 comments · May be fixed by #2270
Open

Check tx status if it's already in cache while broadcasting #2268

shumkov opened this issue Oct 22, 2024 · 0 comments · May be fixed by #2270
Assignees
Labels
enhancement New feature or request

Comments

@shumkov
Copy link
Member

shumkov commented Oct 22, 2024

To mitigate #2261 we need to figure out the status of ST in case we get the "already in cache" error from Tenderdash.
To do so we need to check either ST in mempool (using dashpay/tenderdash#963) or in blockchain (/tx RPC call) or pass it to CheckTx (considering it's invalid) and return validation errors to the client. There might be a case when CheckTx will pass. It's a buggy condition meaning there is inconsistency between CheckTx and block processing logic or some issue in tenderdash. We should log such errors and return the internal error to the client.

@shumkov shumkov added the enhancement New feature or request label Oct 22, 2024
@shumkov shumkov self-assigned this Oct 22, 2024
@shumkov shumkov linked a pull request Oct 22, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant