Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failed Feature Flags contract #2222

Open
lordbah opened this issue Oct 7, 2024 · 2 comments
Open

Test failed Feature Flags contract #2222

lordbah opened this issue Oct 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@lordbah
Copy link

lordbah commented Oct 7, 2024

Expected Behavior

Tests should pass.

Current Behavior

✖ @dashevo/feature-flags-contract at packages/feature-flags-contract 4.891s
✖ test 4.881s
✖ test:unit 4.864s
✖ $ mocha 'test/unit/**/*.spec.js' 4.779s


│ Feature Flags contract
│ 1) "before each" hook for "should have a valid contract definition"


│ 0 passing (2s)
│ 1 failing

│ 1) Feature Flags contract
│ "before each" hook for "should have a valid contract definition":
│ JsonSchemaError: "position" is a required property, path: /properties/block/properties/maxBytes

Possible Solution

Steps to Reproduce (for bugs)

  1. yarn test

Context

Your Environment

repo cloned as of 5e996ed (7-Oct-2024)
Built per README
PopOS 22.04 (Ubuntu)

@lordbah lordbah added the bug Something isn't working label Oct 7, 2024
@pshenmic
Copy link
Collaborator

pshenmic commented Oct 8, 2024

Yeah, feature flags data contract schema is invalid and missing position, I don't know why, most likely has to be forgotten to update. I'm not sure we use this data contract anymore though

@shumkov
Copy link
Member

shumkov commented Oct 17, 2024

We don't use this data contract anymore. We should remove it form repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants