Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashmate): validate SSL certificate files #2089

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 28, 2024

Issue being fixed or feature implemented

It appeared as a common problem that people do not include server certificates in certificate chain file

What was done?

  • Added explanation to include server certificate in certificate chain file
  • Validate that certificate chain file corresponds to private key

How Has This Been Tested?

Passing valid and invalid cert files to dashmate setup.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.1.x milestone Aug 28, 2024
lklimek
lklimek previously approved these changes Aug 28, 2024
@shumkov shumkov merged commit 34b0f8b into master Aug 29, 2024
20 of 21 checks passed
@shumkov shumkov deleted the feat/dashmate/validate-ssl-files branch August 29, 2024 12:06
@thephez thephez added the dashmate Dashmate related label Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashmate Dashmate related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants