Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dapi): serve even if tenderdash is not connected #2086

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Aug 27, 2024

Issue being fixed or feature implemented

During activation or any other reason when Tenderdash RPC is not responding we still want DAPI to respond to RPC requests which aren't required Tenderdash to operate.

What was done?

  • Do not block API to start if tenderdash is not connected
  • Respond with Unavilable gRPC error from endpoints that require Tenderdash to be responding
  • Removed two unused endpoints

How Has This Been Tested?

Tested locally

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title feat(dapi): respond to RPC even tenderdash is not connected feat(dapi): serve even if tenderdash is not connected Aug 27, 2024
pshenmic
pshenmic previously approved these changes Aug 27, 2024
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

packages/dapi/scripts/api.js Show resolved Hide resolved
packages/dapi/scripts/api.js Show resolved Hide resolved
@shumkov shumkov merged commit 327b709 into v1.2-dev Aug 29, 2024
19 of 24 checks passed
@shumkov shumkov deleted the feat/dapi/respond-if-tenderdash-is-not-started branch August 29, 2024 13:32
@thephez thephez added this to the v1.2.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants