Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapi): getTotalCreditsOnPlatform missing parts #2059

Merged
merged 37 commits into from
Aug 14, 2024

Conversation

pshenmic
Copy link
Collaborator

Issue being fixed or feature implemented

Merging changes from the #2051

The CI in the repository is not working correctly with repo forks giving build fails each time.

What was done?

Fixed JS leftovers for the getTotalCreditsOnPlatform query

How Has This Been Tested?

Locally + grpcurl

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

…sOnPlatformQuery

# Conflicts:
#	packages/js-dapi-client/lib/methods/platform/getTotalCreditsInPlatform/GetTotalCreditsInPlatformResponse.js
@pshenmic pshenmic added this to the v1.1.0 milestone Aug 14, 2024
@pshenmic pshenmic self-assigned this Aug 14, 2024
@pshenmic pshenmic changed the title fix(js-dapi-client): getTotalCreditsOnPlatform missing parts fix(dapi): getTotalCreditsOnPlatform missing parts Aug 14, 2024
@shumkov shumkov merged commit 7accd40 into v1.1-dev Aug 14, 2024
51 checks passed
@shumkov shumkov deleted the feat/platform-credits-js-fix branch August 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants